ddl: Support some definitions and fix a bug to modify|change column
#2629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coocood
reviewed
Feb 13, 2017
| @@ -846,6 +846,10 @@ func modifiable(origin *types.FieldType, to *types.FieldType) bool { | |||
| return false | |||
| } | |||
| default: | |||
| if origin.Tp == to.Tp { | |||
There was a problem hiding this comment.
Need to check Flen, Decimal and Flag?
There was a problem hiding this comment.
There are checked in line819-830.
shenli
reviewed
Feb 13, 2017
| if err != nil { | ||
| return errors.Trace(err) | ||
| return ErrColumnBadNull.Gen("invalid default value - %s", err) |
ddl/ddl_api.go
Outdated
| col.Flag &= ^uint(mysql.NotNullFlag) | ||
| case ast.ColumnOptionOnUpdate: | ||
| if !expression.IsCurrentTimeExpr(opt.Expr) { | ||
| return ErrInvalidOnUpdate.Gen("invalid ON UPDATE for - %s", col.Name) |
There was a problem hiding this comment.
This check is done at the parsing layer In MySQL. But we didn't do that. I will fix it in the next PR.
There was a problem hiding this comment.
And now we only support the type of current_timestamp. I will add a TODO here.
|
LGTM |
|
PTAL @shenli |
|
LGTM |
shenli
approved these changes
Feb 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR for the statement of
alter table ... modify|change column.Support the following definitions: 'not null', 'null', 'default value' and 'comment'.
Fix the same type of change.